Skip to content

Remove redundant box-sizing rule - #414

Open
maurer2 wants to merge 1 commit into
TanStack:mainfrom
maurer2:patch-1
Open

Remove redundant box-sizing rule#414
maurer2 wants to merge 1 commit into
TanStack:mainfrom
maurer2:patch-1

Conversation

@maurer2

@maurer2 maurer2 commented Mar 17, 2026

Copy link
Copy Markdown

Hello, after scaffolding a router project, the generated app includes a redundant box-sizing rule. Tailwind already applies box-sizing in the base layer via its preflight styles. This doesn’t really affect styling, but it does create unnecessary noise in the devtools.

image

Cheers

Summary by CodeRabbit

  • Style
    • Updated the default styling rules in the project template.
@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c03bc4a4-4f82-4b20-afff-4b7f8202a274

📥 Commits

Reviewing files that changed from the base of the PR and between b8f4e63 and ccc9004.

📒 Files selected for processing (1)
  • packages/create/src/frameworks/react/project/base/src/styles.css.ejs
💤 Files with no reviewable changes (1)
  • packages/create/src/frameworks/react/project/base/src/styles.css.ejs

📝 Walkthrough

Walkthrough

A CSS reset rule applying box-sizing: border-box globally via a universal selector is removed from the React template stylesheet. The stylesheet continues to include styling for html, body, and #app elements, but the universal box-sizing rule is no longer present.

Changes

Cohort / File(s) Summary
CSS Reset Removal
packages/create/src/frameworks/react/project/base/src/styles.css.ejs
Removed the universal selector block that applied box-sizing: border-box globally, eliminating the global CSS reset rule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A border-box reset did fade away,
No universal rules to sway the day,
The rabbit hops through styles so clean,
Letting browsers chart their scene! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove redundant box-sizing rule' accurately summarizes the main change—removing a box-sizing declaration from the generated CSS file that was redundant with Tailwind's preflight styles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

@maurer2 maurer2 changed the title Remove redundant box-sizing rules Mar 17, 2026
@maurer2
maurer2 marked this pull request as ready for review March 17, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant