Fix 168 - #175
Open
jeff-dh wants to merge 13 commits into
Open
Conversation
(and added missing newline before EOF)
- parse_scad_callables now receives a filename -> write test_code to tempfile - since the code get written to a file string escapes need to be double escaped ;) - corrected syntax in var_with_functions parameters
- I hope this works for everybody else, but I think it should
- could this maybe fix the "MacOS mcad issue" from SolidCode#170
- I'm pretty sure this is what it is supposed to be - I would suggest to rename the function to `resolve_scad_filename`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168
Based again ontop of #170
The additional commits are
7f65b21
a2e6b05
I had to extact _find_library into helpers.py to be able to import it into objects.py and solidpython.py.