builder: implement pointer atomics (missing in SPIR-V) via integers.#559
Draft
eddyb wants to merge 1 commit into
Draft
builder: implement pointer atomics (missing in SPIR-V) via integers.#559eddyb wants to merge 1 commit into
eddyb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This won't do anything useful on Rust-GPU
mainfor a while (since it relies on introducing pointer<->integer casts), but it avoids generating SPIR-V atomic accesses of pointer types (AFAIK illegal even in OpenCL SPIR-V).While the implementation is really tiny (thanks to pre-existing
bitcasting), you could imaginecoreimplementingAtomicPtr<_>on top ofAtomicUsizewith pointer<->integer casts around every operation.TODO: is this testable in any way yet?