Exclude rules-engine-internal from public sealed/data class detekt rules#3581
Merged
ajpallares merged 1 commit intoJun 10, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
tonidero
approved these changes
Jun 10, 2026
tonidero
left a comment
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Ah indeed makes sense. Thanks!
ajpallares
deleted the
pallares/exclude-rules-engine-internal-from-detekt-rules
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rules-engine-internalis an internal module whose API is only consumed by other the RevenueCat SDK, so API-compatibility concerns behindForbiddenPublicSealedClassandForbiddenPublicDataClassdon't apply.Description
Adds
**/rules-engine-internal/**to theexcludesof both rules inconfig/detekt/detekt.yml.Note
Low Risk
Static analysis config only; no runtime or public SDK API behavior changes.
Overview
Detekt is updated so
rules-engine-internalis treated likeexamples: paths under**/rules-engine-internal/**are excluded fromForbiddenPublicDataClass(libraries) andForbiddenPublicSealedClass(revenuecat).That lets the internal rules-engine module use public data/sealed types without the SDK’s public-API compatibility lint, since it is only consumed inside the SDK.
Reviewed by Cursor Bugbot for commit f9179f6. Bugbot is set up for automated code reviews on this repo. Configure here.