Skip to content

Rename library to openscap_results_parser - #23

Open
redhatrises wants to merge 1 commit into
OpenSCAP:masterfrom
redhatrises:master
Open

Rename library to openscap_results_parser#23
redhatrises wants to merge 1 commit into
OpenSCAP:masterfrom
redhatrises:master

Conversation

@redhatrises

Copy link
Copy Markdown
  • openscap_parser has a connotation that this library is performing as a SCAP validator, content scanner, and/or check engine. This PR removes that incorrect connotation. Other suggestions can be made but openscap_parser is a no-go.
- openscap_parser has a connotation that this library is performing as a SCAP validator, content scanner,
  and/or check engine. This PR removes that incorrect connotation.

@akofink akofink left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openscap_results_parser indicates that this gem only parses XCCDF test result files, but it also parses XCCDF datastream and tailoring files as well. I'm not sure how "openscap_parser" makes it seem like this gem does any kind of scanning/evaluation. I think the most accurate name would probably be xccdf_parser as it covers all the file types in that spec.

@redhatrises

Copy link
Copy Markdown
Author

openscap_results_parser indicates that this gem only parses XCCDF test result files, but it also parses XCCDF datastream and tailoring files as well. I'm not sure how "openscap_parser" makes it seem like this gem does any kind of scanning/evaluation. I think the most accurate name would probably be xccdf_parser as it covers all the file types in that spec.

I like your sugestion of xccdf_parser because this isn't really an OpenSCAP parser as it doesn't even use OpenSCAP. Will update to make that distinction.

@kbrock

kbrock commented Jan 26, 2022

Copy link
Copy Markdown

If you like this idea, probably want to merge this sooner than later.
This is begging to be a conflict magnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants