Skip to content

(I001) check om version for the model executable - #446

Merged
adeas31 merged 1 commit into
OpenModelica:masterfrom
syntron:I001-check_om_version_model_executable
Aug 24, 2026
Merged

(I001) check om version for the model executable#446
adeas31 merged 1 commit into
OpenModelica:masterfrom
syntron:I001-check_om_version_model_executable

Conversation

@syntron

@syntron syntron commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

due to changes in OMC, there are 2 different ways to define simulation parameters (pre and post 1.26.0). Currently, the version string needs to be correctly defined for the runner class. This PR adds a check of the xml file to extract the version string from there.

see discussion in PR #401

@syntron
syntron force-pushed the I001-check_om_version_model_executable branch from e4cf36f to 6d8ecd9 Compare March 9, 2026 19:46
@syntron
syntron force-pushed the I001-check_om_version_model_executable branch from 6d8ecd9 to efd6775 Compare May 11, 2026 18:53
@syntron
syntron force-pushed the I001-check_om_version_model_executable branch 4 times, most recently from 2107aff to 6d67447 Compare June 30, 2026 19:50
@syntron
syntron force-pushed the I001-check_om_version_model_executable branch from 6d67447 to eb7ef6c Compare August 10, 2026 19:53
@adeas31

adeas31 commented Aug 11, 2026

Copy link
Copy Markdown
Member

Please make the linter happy.

@syntron

syntron commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Please make the linter happy.

I did focus on PR #468 and #448 as these would be the next; however, to speed it up, we could also jump ...

@syntron
syntron force-pushed the I001-check_om_version_model_executable branch 2 times, most recently from f098ae5 to f87f9f7 Compare August 14, 2026 17:04
@syntron
syntron force-pushed the I001-check_om_version_model_executable branch from f87f9f7 to 29be4a6 Compare August 21, 2026 19:07
@adeas31
adeas31 merged commit 25b7ee3 into OpenModelica:master Aug 24, 2026
10 checks passed
@syntron
syntron deleted the I001-check_om_version_model_executable branch August 26, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants