update usage of flake8 - #357
Merged
Merged
Conversation
Member
|
Please rebase. |
* function names * PEP8 renames in pyparsing (setParseAction() => set_parse_action()) * long lines
Contributor
Author
Done; see also #361 for an overview |
adeas31
approved these changes
Nov 5, 2025
adeas31
enabled auto-merge (squash)
November 5, 2025 12:17
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 5, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 6, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 7, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 8, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 9, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 18, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Feb 26, 2026
flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446)
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Apr 1, 2026
add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Apr 14, 2026
add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Apr 16, 2026
add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Apr 17, 2026
add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Apr 30, 2026
add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400
adeas31
added a commit
that referenced
this pull request
May 11, 2026
* (D006) small fixes in ModelicaSystem [ModelicaSystemABC] reorder code in __init__() [ModelicaSystem*] linter fixes * (D008) add v4.0.0 compatibility layer [OMTypedParser] compatibility layer [__init__/OMCSession] prepare compatibility layer [ModelicaSystem] define as compatibility layer [ModelicaSystemCmd] define as compatibility layer * (D007) define unittest / workflow for v4.0.0 add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400 * cleanup github workflow - use the default one to run all tests * fix name for v4.0.0 test - test*s*_v400 * update name / title for unittest tests_v400 * Increase timeout to 45 minutes --------- Co-authored-by: Adeel Asghar <adeel.asghar@liu.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.toml was introduced in #246; however setup.py is still used for flake8 configuration
This PR
(1) removes the file setup.py (by using Flake8-pyproject)
and
(2) fixes all remaining flake8 warnings (which were deactivated via options)
Additionally, OMTypedParser is updated; this part could be removed / reduced if requested
Milestone: 4.1.0