ModelicaSystem update __init__() - #350
Merged
Merged
Conversation
syntron
force-pushed
the
ModelicaSystem_init
branch
from
August 25, 2025 20:23
5bfd5b7 to
297c77c
Compare
syntron
marked this pull request as ready for review
August 25, 2025 20:36
syntron
force-pushed
the
ModelicaSystem_init
branch
from
August 26, 2025 18:58
297c77c to
df4805a
Compare
Closed
syntron
force-pushed
the
ModelicaSystem_init
branch
from
October 15, 2025 18:50
df4805a to
e255d27
Compare
syntron
force-pushed
the
ModelicaSystem_init
branch
from
October 30, 2025 20:34
e255d27 to
e06ff5d
Compare
Member
|
Please rebase. |
syntron
force-pushed
the
ModelicaSystem_init
branch
from
November 4, 2025 16:42
e06ff5d to
8feeff7
Compare
Contributor
Author
Done; see also #361 for an overview |
syntron
force-pushed
the
ModelicaSystem_init
branch
4 times, most recently
from
November 5, 2025 22:03
ae66564 to
18dd4f2
Compare
Member
|
Need to rebase again. |
new: * __init__() - initialisation * model_definition() - model related definitions
syntron
force-pushed
the
ModelicaSystem_init
branch
from
November 6, 2025 14:09
3ae06c2 to
d8228d2
Compare
adeas31
requested changes
Nov 10, 2025
adeas31
approved these changes
Nov 13, 2025
adeas31
left a comment
adeas31
left a comment
Member
There was a problem hiding this comment.
LGTM.
This is a breaking change as the interface to ModelicaSystem is changed so please update the UsersGuide accordingly https://openmodelica.org/doc/OpenModelicaUsersGuide/latest/ompython.html#ompython
At sometime we should also include all the new features of OMPython in UsersGuide.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #305
This PR splits
__init__()into two parts:__init__()- main initialisationmodel()- all model related definitions (was old:definition())This allows to use
convertFmu2Mo()after a instanciation ofModelicaSystem()for the definition of the model to be used (this should be done in a separate PR)Defined as a draft to allow a discussion; this will be a breaking change of the API! => milestone 4.1.0?
based on top of PR #349