[ModelicaSystem] update handling of work directory - #329
Merged
Conversation
syntron
commented
Aug 12, 2025
syntron
commented
Contributor
- use as input str or os.PathLike; the later covers all pathlib objects
- rename _tempdir to _work_dir
- rename setTempDirectory() => setWorkDirectory()
- setWorkDirectory() sets the work dir and also returns its path
- use setWorkDirectory() within code; this allows to add special handling to the function if needed
This was referenced Aug 12, 2025
syntron
force-pushed
the
ModelicaSystem_workdir
branch
from
August 16, 2025 13:05
a64a330 to
26e73f6
Compare
adeas31
approved these changes
Aug 19, 2025
* use as input str or os.PathLike; the later covers all pathlib objects * rename _tempdir to _work_dir * rename setTempDirectory() => setWorkDirectory() * setWorkDirectory() sets the work dir and also returns its path * use setWorkDirectory() within code; this allows to add special handling to the function if needed
syntron
force-pushed
the
ModelicaSystem_workdir
branch
from
August 19, 2025 17:59
26e73f6 to
3c45338
Compare
adeas31
enabled auto-merge (squash)
August 20, 2025 09:59
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.