ModelicaSystem - remove csvfile as class variable - #313
Merged
Conversation
syntron
force-pushed
the
ModelicaSystem_csvfile
branch
from
June 25, 2025 19:56
5253c9c to
70a0fb4
Compare
syntron
force-pushed
the
ModelicaSystem_csvfile
branch
2 times, most recently
from
July 2, 2025 19:59
0a131f3 to
bb8a8be
Compare
syntron
force-pushed
the
ModelicaSystem_csvfile
branch
from
July 7, 2025 17:09
bb8a8be to
77cd547
Compare
adeas31
approved these changes
Jul 9, 2025
adeas31
enabled auto-merge (squash)
July 9, 2025 09:39
…resultfile in simulate() reason: * variable not needed / used as class variable * using name based on resultfile allows to run the same model executable several times
auto-merge was automatically disabled
July 9, 2025 18:35
Head branch was pushed to by a user without write access
syntron
force-pushed
the
ModelicaSystem_csvfile
branch
from
July 9, 2025 18:35
1400906 to
945306b
Compare
* rename resultfile => result_file * use local variable result_file and not self._result_file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ModelicaSystem] remove class variable csvFile; define name based on resultfile in simulate()
reason:
on top of PR #311