Omc port from log - #301
Merged
Merged
Conversation
This was referenced Jun 12, 2025
Merged
Closed
syntron
force-pushed
the
OMC_port_from_log
branch
2 times, most recently
from
June 13, 2025 19:53
30449bd to
9724775
Compare
This was referenced Jun 16, 2025
Merged
Merged
syntron
force-pushed
the
OMC_port_from_log
branch
from
June 17, 2025 18:47
9724775 to
0856598
Compare
Member
syntron
force-pushed
the
OMC_port_from_log
branch
from
June 19, 2025 19:57
0856598 to
4501729
Compare
adeas31
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMC writes the ZMQ port into a file which must be found to get this information. Currently OMPython defines the file name in the Python code. However, this information is available in the log of OMC - why not use it?
This code replaces the old way of defining the port file with an evaluation of the log data.
Based on top of PR #295; this should be included in the next release (see #254)