Use subprocess.run - #273
Merged
Merged
Conversation
syntron
force-pushed
the
use_subprocess.run
branch
from
April 29, 2025 18:56
69728a9 to
2b92216
Compare
Collaborator
|
@syntron please resolve the conflicts and update your PR |
syntron
force-pushed
the
use_subprocess.run
branch
from
April 29, 2025 20:47
2b92216 to
863d6b6
Compare
This was referenced Apr 30, 2025
Merged
Merged
Closed
Merged
adeas31
requested changes
May 3, 2025
adeas31
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify subprocess.Popen() by using subprocess.run() in ModelicaSystem._run_cmd()
Reason: the added functionality of Popen() is not used at all in this case ...