Skip to content

Some more code cleanups - #258

Merged
adeas31 merged 3 commits into
OpenModelica:masterfrom
syntron:code_cleanup
Apr 23, 2025
Merged

Some more code cleanups#258
adeas31 merged 3 commits into
OpenModelica:masterfrom
syntron:code_cleanup

Conversation

@syntron

@syntron syntron commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

additional cleanups which should be added before #257

  • Remove unreachable code
  • cleanup old code for Python 2.x
  • fix OMCSessionBase - the variables self.readonly and self.omc_cache are needed here
  • [ModelicaSystem] fix True in docstring
  • [OMCSessionBase] fix usage of excaptions - replace ex.message() by ex.msg()
@syntron

syntron commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

see also discussion in #250 - small changes to make OMCSessionBase and OMCSessionZMQ more independent of each other
@syntron syntron mentioned this pull request Apr 23, 2025
Merged
@adeas31
adeas31 merged commit 8230f67 into OpenModelica:master Apr 23, 2025
@syntron
syntron deleted the code_cleanup branch April 24, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@syntron @adeas31