Skip to content

[ModelicaSystem._run_cmd] use argument cwd of subprocess.Popen() inst… - #251

Closed
syntron wants to merge 1 commit into
OpenModelica:masterfrom
syntron:improve_directory_handling
Closed

[ModelicaSystem._run_cmd] use argument cwd of subprocess.Popen() inst…#251
syntron wants to merge 1 commit into
OpenModelica:masterfrom
syntron:improve_directory_handling

Conversation

@syntron

@syntron syntron commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

use argument cwd of subprocess.Popen() instead of handling directory change on our own

@ondras12345

Copy link
Copy Markdown
Contributor

Just FYI #249 already does this

@syntron

syntron commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

@ondras12345 no problem; could you point me to the exact commit? I checked your commit series yesterday but missed this part ... My version was just sitting in my fork since last year and included it in the updates.

@ondras12345

Copy link
Copy Markdown
Contributor

It's part of this one: 401824d
I have noticed it while cleaning up the code, and unfortunately I didn't do it in a separate commit.

@syntron

syntron commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

It's part of this one: 401824d I have noticed it while cleaning up the code, and unfortunately I didn't do it in a separate commit.

Looks fine (and is at the end the same code change ;-) )

@adeas31

adeas31 commented Apr 17, 2025

Copy link
Copy Markdown
Member

As I understand this PR is already by #249, if this is the case then @syntron please close it.

@syntron

syntron commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

As I understand this PR is already by #249, if this is the case then @syntron please close it.

Done

@syntron syntron closed this Apr 17, 2025
@syntron
syntron deleted the improve_directory_handling branch April 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants