Skip to content

Merge Staging - #116

Merged
xlcrr merged 104 commits into
masterfrom
staging
Nov 15, 2021
Merged

Merge Staging#116
xlcrr merged 104 commits into
masterfrom
staging

Conversation

@xlcrr

@xlcrr xlcrr commented Oct 17, 2021

Copy link
Copy Markdown
Member

No description provided.

@xlcrr xlcrr mentioned this pull request Oct 17, 2021
lat: item.node.location.latitude,
lon: item.node.location.longitude,
timestamp: item.node.timestamp,
date: item.node.timestamp,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this date or timestamp? Comment would be good here

@sudoDeznit sudoDeznit Nov 15, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the key from timestamp to date SO that both gallery and camera image have same key . The value here is in epoch timestamp

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the value is timestamp, then the key should also be timestamp?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it date because API was date and generally timestamps are used for dates.

timestamp: item.node.timestamp,
date: item.node.timestamp,
selected: false,
picked_up: false,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not initialising this?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is when we load geotagged cameraroll/gallery images to state, we don't need to add picked_up here..
We add pickedUp in ADD_IMAGES i.e when we select gallery image

Comment thread actions/images_action.js
@xlcrr
xlcrr merged commit 2061ca8 into master Nov 15, 2021
sudoDeznit added a commit that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants