fix(release_homebrew): reduce test duplication - #238
Merged
ReenigneArcher merged 5 commits intoJun 25, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1608 1608
Branches 175 175
=========================================
Hits 1608 1608
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Rename the test-artifacts env var to HOMEBREW_TEST_ARTIFACTS_DIR and update docs/action metadata. Add get_homebrew_test_artifacts_dir(), cleaning logic for Homebrew logs under logs/release_homebrew, and copy_test_artifacts() to copy artifacts from the Homebrew-side logs into the action-owned testpath. brew_test_bot_only_formulae now exposes the Homebrew artifacts path to test-bot and, when given a testpath, copies any produced artifacts back to the action output. Tests and README/action.yml were updated to cover the new helper, cleanup behavior, env var and copying behavior.
Add HOMEBREW_LOGS support and make test artifact directories per-formula under a Homebrew logs root. - Expose HOMEBREW_LOGS env var and add HOMEBREW_TEST_ARTIFACTS_DIR usage to README. - Add get_homebrew_logs_dir() to return GITHUB_WORKSPACE/release_homebrew_action/homebrew_logs. - Change get_homebrew_test_artifacts_dir() and prepare_test_artifacts_dir() to accept a formula name and locate artifacts under the per-formula logs directory so macOS bottle builds can write from the sandbox. - Ensure required directories are created and set HOMEBREW_LOGS in brew_test_bot environment when running test-bot. - Update tests to cover the new logs root and per-formula artifact paths.
Replace the previous HOMEBREW_LOGS-based layout with HOMEBREW_TEMP rooted at the OS temp directory. Rename get_homebrew_logs_dir to get_homebrew_temp_dir, update paths to use tempfile.gettempdir(), and set HOMEBREW_TEMP in the test-bot environment. Update README to document HOMEBREW_TEMP and adjust tests to match the new env var and function names. Also import tempfile where needed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try to reduce release_homebrew actions duplicated builds.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage