Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Form Builder block not tagging the subscriber or adding them to the Sequence when adding the subscriber to the Form failed.
After creating the subscriber,
$resultwas overwritten by the add to Form request. The Tag and Sequence requests then read the subscriber ID from$result['subscriber']['id']. If the Form request failed,$resultwas aWP_Error, so the subscriber ID was missing and the Tag and Sequence requests failed.The subscriber ID is now stored once, after the subscriber is created, and used for the Form, Tag and Sequence requests.
Testing
New Integration test in
BlockFormBuilderTest:testTagAndSequenceWhenAddingSubscriberToFormFails: mocks the add to Form request returning an error, and confirms the subscriber is still tagged and added to the Sequence. Fails without this fix.Checklist