Conversation
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Form Builder block displaying a validation error on every Form Builder block on a Page, and jumping to the first block, when a visitor submits a form further down the Page.
The submission error was stored once per request, and every Form Builder block on the Page added the error notice and
autofocusattribute, so the browser focused the first block. This was reported by a creator with two Form Builder blocks on their homepage: submitting the second block with an invalid email address jumped back to the first block's error.Each block now outputs its index on the Page as a hidden
convertkit[block_index]field. The error notice,aria-invalidandautofocusare only added to the block that was submitted, so the visitor is taken to that block and its error. If no index is submitted (e.g. a page cached before this update), the error is displayed on all blocks, as before.Testing
New Integration tests in
BlockFormBuilderMultipleFormsTest:testBlockIndexHiddenField: each block outputs its index. Fails without this fix.testErrorDisplayedOnSubmittedBlockOnly: the error notice,aria-invalidandautofocusare only added to the submitted block. Fails without this fix.testErrorDisplayedOnAllBlocksWhenNoBlockIndex: the existing behaviour is kept when no index is submitted.New E2E test,
PageBlockFormBuilderCest::testFormBuilderBlockWithInvalidEmailAddressInSecondBlock:Checklist