Skip to content

Tests: Add waitForSubscriber and retryUntil helper methods - #158

Merged
n7studios merged 2 commits into
masterfrom
tests-fix-unsubscribe
Sep 9, 2026
Merged

n7studios merged 2 commits into
masterfrom
tests-fix-unsubscribe

Conversation

@n7studios

Copy link
Copy Markdown
Contributor

Summary

Adds a retryUntil helper for tests, as subscriber creation isn't always immediately reflected in the API:
https://developers.kit.com/api-reference/eventual-consistency

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Sep 8, 2026
@n7studios n7studios changed the title Tests: Unsubscribe: Wait for subscriber Sep 8, 2026
@n7studios n7studios changed the title Tests: Wait for Subscriber Sep 8, 2026
@n7studios
n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team September 8, 2026 09:22
@n7studios
n7studios marked this pull request as ready for review September 8, 2026 09:22

@ciccio-kit ciccio-kit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@n7studios
n7studios merged commit 07c933d into master Sep 9, 2026
20 of 24 checks passed
@n7studios
n7studios deleted the tests-fix-unsubscribe branch September 9, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants