Skip to content

Support for postponed annotations - #292

Open
haizaar wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
haizaar:postponed_annotations
Open

Support for postponed annotations#292
haizaar wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
haizaar:postponed_annotations

Conversation

@haizaar

@haizaar haizaar commented Nov 30, 2023

Copy link
Copy Markdown

Fixes #291
@haizaar

haizaar commented Nov 30, 2023

Copy link
Copy Markdown
Author

eval_str was added to the signature function only in Python3.10, so this fix is only for 3.10+
@HKWinterhalter

HKWinterhalter commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Thank you for making this fix! Looks like we need three things for this to pass:

  • Python Lint is complaining about format.
  • to pass conventionalcommit, the commit message should be something like "fix: Support for postponed annotations" (i.e. prepend with "fix:")
  • Test coverage
@HKWinterhalter HKWinterhalter removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@haizaar @HKWinterhalter