Skip to content

FEATURE: Added task:clean to truncate execution history database - #23

Merged
dlubitz merged 15 commits into
Flowpack:mainfrom
KilianKluge:dev/truncate-command
Aug 13, 2026
Merged

FEATURE: Added task:clean to truncate execution history database#23
dlubitz merged 15 commits into
Flowpack:mainfrom
KilianKluge:dev/truncate-command

Conversation

@KilianKluge

Copy link
Copy Markdown
Contributor

FEATURE: Added task:clean to truncate execution history database

@dlubitz dlubitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KilianKluge for this PR. Looks good to me, but I left some suggestions to improve type safety.

Comment thread Classes/Command/TaskCommandController.php Outdated
Comment thread Classes/Domain/Repository/TaskExecutionRepository.php Outdated
Comment thread Classes/Domain/Repository/TaskExecutionRepository.php Outdated
Comment thread Classes/Domain/Repository/TaskExecutionRepository.php Outdated
Comment thread Classes/Domain/Repository/TaskExecutionRepository.php Outdated
Comment thread Classes/Domain/Repository/TaskExecutionRepository.php Outdated
     changed parameter order
     moved string ops to command
     added method documentation
     fixed code style
@KilianKluge
KilianKluge requested a review from dlubitz August 13, 2026 09:07
Comment thread Classes/Command/TaskCommandController.php Outdated
Comment thread Classes/Domain/Repository/TaskExecutionRepository.php Outdated
Comment thread Classes/Command/TaskCommandController.php Outdated
@dlubitz dlubitz changed the title Dev/truncate command Aug 13, 2026
@KilianKluge
KilianKluge requested a review from dlubitz August 13, 2026 13:02
@dlubitz
dlubitz merged commit 1784ee6 into Flowpack:main Aug 13, 2026
9 checks passed
@dlubitz

dlubitz commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thank you @KilianKluge! Is merged. I'll create a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants