Skip to content

fix: check deny list in for certain chat models#6589

Open
0xi4o wants to merge 5 commits into
mainfrom
fix/flowise-555
Open

fix: check deny list in for certain chat models#6589
0xi4o wants to merge 5 commits into
mainfrom
fix/flowise-555

Conversation

@0xi4o

@0xi4o 0xi4o commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates checkDenyList security checks across multiple chat model components to validate base URLs and paths. The review feedback highlights a critical SSRF vulnerability in the Ollama component where an empty baseUrl defaults to localhost and bypasses the check. Additionally, the reviewer suggests combining redundant if conditions for baseUrl and basePath to improve code readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/components/nodes/chatmodels/ChatOllama/ChatOllama.ts Outdated
Comment thread packages/components/nodes/chatmodels/ChatLocalAI/ChatLocalAI.ts Outdated
0xi4o and others added 4 commits July 1, 2026 14:52
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…hatCloudflareWorkersAI.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@0xi4o 0xi4o marked this pull request as ready for review July 1, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant