Add forward rules for triangular linear solves#3107
Conversation
|
@wsmoses I added these in. I think this is a better place to fix some of those issues than the tablegen for now (and it is symmetric to the reverses-rules, so not coming out of nowhere). |
|
This is fine for now, but I do think this may make sense to do as a tablegen rule. For regular matmul we saw substantial speed ups in doing so. Assuming this directly translates to the blas call [and not a combination of calls], I would expect similar here |
|
Definitely. If you want any more work on the EnzymeAD/Enzyme#2825 just post comments or a code review and I will tell the AI to do its thing. But while I don't mind using AIs for patching, I am loathe to do so when I don't understand the code. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3107 +/- ##
==========================================
- Coverage 70.04% 69.95% -0.09%
==========================================
Files 66 66
Lines 21840 21866 +26
==========================================
Hits 15297 15297
- Misses 6543 6569 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think you still need to address the previous comments there, involving both splitting it up and also just changing the relefvant pieces? |
|
@wsmoses Sorry, I think a question might have been lost on slack. To clarify, I wasn't sure if you wanted me to split EnzymeAD/Enzyme#2825 into 3 separate PRs for |
|
yes that's correct |
Summary
_zero_unused_elements!handling for unit triangular structureTests
julia --project=test test/runtests.jl --verbose rules/internal_rules/linear_algebra_rules