fix(editor): hide empty container placeholder for inline styles#148
Draft
DavidBabinec wants to merge 1 commit into
Draft
fix(editor): hide empty container placeholder for inline styles#148DavidBabinec wants to merge 1 commit into
DavidBabinec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nodeWrapperProps.styleas authored styling for emptybase.containernodes in the editor canvas.Empty containeraffordance.Why
Class-styled empty containers already suppressed the placeholder, but inline-styled empty containers did not because
ContainerEditoronly checkedmcClassName. That made the canvas behavior inconsistent between class and inline styling.Impact
Authors can style empty containers inline for spacer/background/positioning use cases without the canvas showing the empty-state label over the authored element.
Verification
bun test src/__tests__/base-modules-shared-render.editor.test.tsx(red before fix, green after)bun testbun run buildbun run lintnpx react-doctor@latest --verbose --scope changed --base origin/main