Skip to content

chore: Update nodes categories#14674

Merged
alexisrolland merged 13 commits into
masterfrom
alexis/nodes-categories-update
Jun 30, 2026
Merged

chore: Update nodes categories#14674
alexisrolland merged 13 commits into
masterfrom
alexis/nodes-categories-update

Conversation

@alexisrolland

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 68dfdbc3-47a8-4361-af0f-152728bb599e

📥 Commits

Reviewing files that changed from the base of the PR and between 9c33607 and 62d381b.

📒 Files selected for processing (1)
  • nodes.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • nodes.py

📝 Walkthrough

Walkthrough

This PR updates node schema metadata across several files. It moves multiple nodes from experimental categories into model-oriented categories, adds or changes display names for some nodes, removes advanced=True from two T5TokenizerOptions inputs, and changes one Stable Cascade category string to use a space instead of an underscore.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the intent is too vague to assess meaningfully. Add a brief description explaining the node category and display-name updates made in this PR.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating node categories.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_extras/nodes_cond.py`:
- Around line 41-44: The tokenizer inputs on the node in nodes_cond.py are still
intended to stay hidden from the default UI, so keep advanced=True on the
min_padding and min_length declarations inside the affected node definition.
Restore those flags in the input schema for the relevant node class/method so
the existing node interface and serialized schema remain unchanged for
downstream clients.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ed30198-19c2-4271-aedb-4274584489d3

📥 Commits

Reviewing files that changed from the base of the PR and between a58473f and 9c33607.

📒 Files selected for processing (6)
  • comfy_extras/nodes_cond.py
  • comfy_extras/nodes_custom_sampler.py
  • comfy_extras/nodes_photomaker.py
  • comfy_extras/nodes_stable_cascade.py
  • comfy_extras/nodes_triposplat.py
  • nodes.py
Comment thread comfy_extras/nodes_cond.py
@alexisrolland alexisrolland changed the title chore: Update nodes categorie Jun 29, 2026
@alexisrolland alexisrolland merged commit 6e11828 into master Jun 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants