Skip to content

feat: add enable_telemetry CLI feature flag#14530

Merged
comfyanonymous merged 1 commit into
masterfrom
feat/enable-telemetry-feature-flag
Jun 18, 2026
Merged

feat: add enable_telemetry CLI feature flag#14530
comfyanonymous merged 1 commit into
masterfrom
feat/enable-telemetry-feature-flag

Conversation

@Kosinkadink

Copy link
Copy Markdown
Member

Adds an enable_telemetry flag to CLI_FEATURE_FLAG_REGISTRY (bool, default False), mirroring show_signin_button. Launchers can set it via --feature-flag enable_telemetry=true to signal the frontend that telemetry collection is enabled; it ships to the frontend over the WS capability handshake and is discoverable via --list-feature-flags. Default off means nothing changes unless a launcher opts in.

Paired with Comfy-Desktop launcher support (Comfy-Org/Comfy-Desktop) that only sets the flag for opted-in standalone installs.

Ref: Comfy-Org/Comfy-Desktop#1142

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8f5be7e1-2532-4f83-b11b-b74fea4b4b8d

📥 Commits

Reviewing files that changed from the base of the PR and between 52257bb and 26d279d.

📒 Files selected for processing (1)
  • comfy_api/feature_flags.py

📝 Walkthrough

Walkthrough

A new boolean feature flag, enable_telemetry, is added to CLI_FEATURE_FLAG_REGISTRY in comfy_api/feature_flags.py. The flag has type bool, a default value of False, and a description indicating it signals telemetry enablement to the frontend. No other files are modified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a new CLI-settable feature flag named enable_telemetry.
Description check ✅ Passed The description is directly related to the changeset, providing context about the enable_telemetry flag, its usage, and coordination with Comfy-Desktop.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit f2270f0 into master Jun 18, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the feat/enable-telemetry-feature-flag branch June 18, 2026 02:35
@PlagueKind

Copy link
Copy Markdown

I don't want telemetry in my comfyui. I have no intention of using the desktop app. Is this nonsense disabled by default?

@Kosinkadink

Kosinkadink commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Look at the code, it's 5 lines. All it does is pass the flag to the frontend. This adds zero telemetry on its own anywhere in ComfyUI.

zhangp365 pushed a commit to zhangp365/ComfyUI that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants