feat: add enable_telemetry CLI feature flag#14530
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ed7b7-9733-752f-9709-e75510d0f380 Co-authored-by: Amp <amp@ampcode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new boolean feature flag, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I don't want telemetry in my comfyui. I have no intention of using the desktop app. Is this nonsense disabled by default? |
|
Look at the code, it's 5 lines. All it does is pass the flag to the frontend. This adds zero telemetry on its own anywhere in ComfyUI. |
Adds an
enable_telemetryflag toCLI_FEATURE_FLAG_REGISTRY(bool, defaultFalse), mirroringshow_signin_button. Launchers can set it via--feature-flag enable_telemetry=trueto signal the frontend that telemetry collection is enabled; it ships to the frontend over the WS capability handshake and is discoverable via--list-feature-flags. Default off means nothing changes unless a launcher opts in.Paired with Comfy-Desktop launcher support (Comfy-Org/Comfy-Desktop) that only sets the flag for opted-in standalone installs.
Ref: Comfy-Org/Comfy-Desktop#1142