Skip to content

Add negative prompt to boogu edit node and set min images to 0.#14529

Merged
comfyanonymous merged 1 commit into
masterfrom
temp_pr
Jun 17, 2026
Merged

Add negative prompt to boogu edit node and set min images to 0.#14529
comfyanonymous merged 1 commit into
masterfrom
temp_pr

Conversation

@comfyanonymous

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two changes are made to Boogu model support. In comfy/supported_models.py, the Boogu class attribute memory_usage_factor is raised from 1.95 to 2.15. In comfy_extras/nodes_boogu.py, the TextEncodeBooguEdit node gains a new advanced negative_prompt input in define_schema, the images autogrow template minimum is lowered from 1 to 0, the execute method signature is updated to receive negative_prompt, and negative conditioning is now produced by tokenizing and encoding that parameter instead of a hardcoded empty string.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author; the PR is missing contextual information about the changes and their rationale. Add a brief description explaining why the negative prompt input was added and why the minimum images threshold was changed to 0.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: adding a negative prompt parameter to the TextEncodeBooguEdit node and setting the minimum images to 0.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_extras/nodes_boogu.py`:
- Line 29: The `negative_prompt` input added to the `TextEncodeBooguEdit` node
is currently required, which breaks backward compatibility with existing saved
workflows that do not include this field. Modify the `io.String.Input`
definition for `negative_prompt` to include a default value of an empty string,
and ensure the `execute()` method also handles the case where `negative_prompt`
defaults to an empty string when not provided. This preserves the existing node
interface while supporting the new functionality for workflows that do provide
the value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec20cabb-7d31-401e-a044-eabc31999abd

📥 Commits

Reviewing files that changed from the base of the PR and between e25c391 and c358c25.

📒 Files selected for processing (2)
  • comfy/supported_models.py
  • comfy_extras/nodes_boogu.py
inputs=[
io.Clip.Input("clip"),
io.String.Input("prompt", multiline=True, dynamic_prompts=True),
io.String.Input("negative_prompt", multiline=True, dynamic_prompts=True, advanced=True),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Preserve backward compatibility by making negative_prompt optional with a default.

Adding negative_prompt as a required input changes the node interface and can break existing saved workflows that instantiate TextEncodeBooguEdit without this field. Keep the new input, but default it to "" in schema and execute().

Suggested patch
-                io.String.Input("negative_prompt", multiline=True, dynamic_prompts=True, advanced=True),
+                io.String.Input("negative_prompt", default="", multiline=True, dynamic_prompts=True, advanced=True),
@@
-    def execute(cls, clip, prompt, negative_prompt, vae=None, images: io.Autogrow.Type = None) -> io.NodeOutput:
+    def execute(cls, clip, prompt, negative_prompt="", vae=None, images: io.Autogrow.Type = None) -> io.NodeOutput:

As per coding guidelines, comfy_extras/** changes should avoid breaking existing node interfaces.

Also applies to: 48-48

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@comfy_extras/nodes_boogu.py` at line 29, The `negative_prompt` input added to
the `TextEncodeBooguEdit` node is currently required, which breaks backward
compatibility with existing saved workflows that do not include this field.
Modify the `io.String.Input` definition for `negative_prompt` to include a
default value of an empty string, and ensure the `execute()` method also handles
the case where `negative_prompt` defaults to an empty string when not provided.
This preserves the existing node interface while supporting the new
functionality for workflows that do provide the value.

Source: Coding guidelines

@comfyanonymous comfyanonymous merged commit 52257bb into master Jun 17, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the temp_pr branch June 17, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants