Skip to content

PiD: Add SDXL and QwenImage#14240

Merged
comfyanonymous merged 2 commits into
Comfy-Org:masterfrom
kijai:pid
Jun 2, 2026
Merged

PiD: Add SDXL and QwenImage#14240
comfyanonymous merged 2 commits into
Comfy-Org:masterfrom
kijai:pid

Conversation

@kijai

@kijai kijai commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Two new models available, add their latent spaces to the conditioning node.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 57d155ac-0760-47f2-b332-158628bd10ad

📥 Commits

Reviewing files that changed from the base of the PR and between fc704ba and f600cda.

📒 Files selected for processing (1)
  • comfy_extras/nodes_pid.py

📝 Walkthrough

Walkthrough

The PiDConditioning node now offers four latent formats: flux, sd3, sdxl, and qwenimage; its input tooltip was updated. execute() explicitly maps each format value to the corresponding comfy.latent_formats class and raises ValueError for unknown formats. After process_in, execute() handles 5D latents by slicing lq_latent to lq_latent[:, :, 0] before passing it to the conditioning output.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding support for SDXL and QwenImage latent formats to the PiDConditioning node.
Description check ✅ Passed The description is related to the changeset, explaining that new models are being added to the conditioning node by including their latent spaces.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit dc10c01 into Comfy-Org:master Jun 2, 2026
14 checks passed
zhangp365 pushed a commit to zhangp365/ComfyUI that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants