cache-ram: lower thresholds#14089
Conversation
Use the RAM right up to the wire as the community is bit accustomed too. This trades off headroom for the case where large chunky intermediates arrive and potenitally hits pagefile/swap, but a lot of people have "it just fits" workflows out there, so strike a compromise with 75->90%. Disable the incative cache for all but the very high RAM users.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adjusts the default RAM cache sizing behavior in ComfyUI's prompt worker and documents the changes in the CLI help text. The active cache (cache_ram) now allocates 10% of total system RAM instead of 25%, with adjusted minimum and maximum bounds. The inactive cache (cache_ram_inactive) uses a new scaling formula based on total_ram divided by 1024, with an upper cap of 96GB and no minimum bound. The help text is updated to communicate these new thresholds to users. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use the RAM right up to the wire as the community is bit accustomed too. This trades off headroom for the case where large chunky intermediates arrive and potenitally hits pagefile/swap, but a lot of people have "it just fits" workflows out there, so strike a compromise with 75->90%. Disable the incative cache for all but the very high RAM users.
Use the RAM right up to the wire as the community is bit accustomed too.
This trades off headroom for the case where large chunky intermediates arrive and potentially hits pagefile/swap, but a lot of people have "it just fits" workflows out there, so strike a compromise with 75->90%.
Disable the inactive cache for all but the very high RAM users.
Regression Tests:
Windows RTX5060 32GB WAN 2.2 FP16 NVME gen4 ✅
Windows RTX5060 32GB WAN 2.2 FP8 NVME gen4 ✅
Linux RTX5090 64GB RAM WAN 2.2 FP8 ✅
Linux RTX5090 64GB RAM WAN 2.2 FP16 NVME gen1 ✅
Linux RTX5090 64GB RAM stable cascade -> flux2 ✅
Linux RTX5090 64GB RAM ace-step 1.5 turbo XL ✅