Skip to content

Remove dead code.#14072

Merged
comfyanonymous merged 1 commit into
masterfrom
comfyanonymous-patch-1
May 23, 2026
Merged

Remove dead code.#14072
comfyanonymous merged 1 commit into
masterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 47fc68c3-21c7-4aad-935b-b2dc0584ee5f

📥 Commits

Reviewing files that changed from the base of the PR and between 187442c and b04466e.

📒 Files selected for processing (1)
  • comfy/samplers.py
💤 Files with no reviewable changes (1)
  • comfy/samplers.py

📝 Walkthrough

Walkthrough

This PR reduces memory-check bookkeeping overhead in the _calc_cond_batch function by eliminating an intermediate dictionary. Instead of constructing a temporary cond dict with size mappings and then consuming it, the code now directly accumulates conditioning tensor sizes into cond_shapes during a single iteration pass over the conditioning items.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Remove dead code' is vague and generic, lacking specificity about which code or functionality is affected. Consider a more specific title that identifies the affected function or module, such as 'Remove dead code in _calc_cond_batch memory check.'
Description check ❓ Inconclusive No pull request description was provided; while the title suggests dead code removal, without a description it is unclear what code is being removed or why. Add a description explaining which code is being removed, why it is dead, and what the change accomplishes.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit d80fcaf into master May 23, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch May 23, 2026 02:56
simonri pushed a commit to simonri/ComfyUI-flash-attention-3 that referenced this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant