Skip to content

openapi: remove cloud-only job_ids query param from GET /api/assets#14016

Merged
mattmillerai merged 4 commits into
masterfrom
matt/be-1040-remove-cloud-job-ids-asset-param
May 21, 2026
Merged

openapi: remove cloud-only job_ids query param from GET /api/assets#14016
mattmillerai merged 4 commits into
masterfrom
matt/be-1040-remove-cloud-job-ids-asset-param

Conversation

@mattmillerai

Copy link
Copy Markdown
Contributor

Summary

Removes the job_ids query parameter from GET /api/assets in openapi.yaml. The parameter was tagged x-runtime: [cloud] (i.e. it only applies to the cloud variant of this endpoint, not local ComfyUI), but the cloud variant no longer accepts it — the field has no live callers and the cloud-side handler has been removed.

Leaving the [cloud-only] documentation in place would falsely advertise a query parameter that no runtime actually honors.

Scope

  • Single deletion in openapi.yaml (6 lines): the job_ids parameter entry under GET /api/assets.
  • No code changes — this file is a spec document.
  • No effect on local ComfyUI behavior: this parameter was never implemented locally; it was a cloud-only filter folded into the OSS spec under the x-runtime tagging convention.

Test plan

  • No local ComfyUI behavior to test — parameter was never accepted by core.
  • Spec lints / validates.
The job_ids query parameter on GET /api/assets is tagged x-runtime:
[cloud] and only exists for cloud's variant of this endpoint. Cloud
removed all consumers and the cloud-side handler/codegen/tests in
Comfy-Org/cloud#3778. With cloud no longer accepting this parameter,
the [cloud-only] documentation here is wrong — drop it so the daily
sync to cloud/services/ingest/vendor/openapi.yaml propagates the
removal.
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6b04de0-cf79-4c52-96c2-452aa903b254

📥 Commits

Reviewing files that changed from the base of the PR and between 23152a4 and 3ba2414.

📒 Files selected for processing (1)
  • openapi.yaml

📝 Walkthrough

Walkthrough

The PR updates the OpenAPI specification for the GET /api/assets endpoint. The job_ids cloud-only query parameter was removed, and two new cloud-only query parameters were added: include_public (boolean) for including workspace-public assets, and asset_hash (string) for filtering by exact content hash. The specification change updates the API contract for asset listing operations.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: removing the job_ids cloud-only query parameter from GET /api/assets.
Description check ✅ Passed The description clearly explains the change, rationale, scope, and testing approach, all directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@mattmillerai mattmillerai merged commit 1668aaf into master May 21, 2026
17 checks passed
simonri pushed a commit to simonri/ComfyUI-flash-attention-3 that referenced this pull request May 26, 2026
…omfy-Org#14016)

The job_ids query parameter on GET /api/assets is tagged x-runtime:
[cloud] and only exists for cloud's variant of this endpoint. Cloud
removed all consumers and the cloud-side handler/codegen/tests in
Comfy-Org/cloud#3778. With cloud no longer accepting this parameter,
the [cloud-only] documentation here is wrong — drop it so the daily
sync to cloud/services/ingest/vendor/openapi.yaml propagates the
removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants