Skip to content

Remove useless option and clarify what lowvram does.#13922

Merged
comfyanonymous merged 1 commit into
masterfrom
comfyanonymous-patch-1
May 16, 2026
Merged

Remove useless option and clarify what lowvram does.#13922
comfyanonymous merged 1 commit into
masterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6727a82a-c974-44a5-9087-53598dc87c91

📥 Commits

Reviewing files that changed from the base of the PR and between 33ce449 and 72882fd.

📒 Files selected for processing (1)
  • comfy/cli_args.py

📝 Walkthrough

Walkthrough

This PR refactors VRAM-related CLI options in comfy/cli_args.py. The --normalvram option is removed from the mutually-exclusive vram_group, and the --lowvram option is redefined with new semantics: when dynamic VRAM is enabled, the flag is ignored; otherwise, it forces text encoders to run on CPU, replacing the previous behavior of splitting the UNet.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining why the --normalvram option is useless and how the --lowvram behavior change improves clarity.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: removing the --normalvram option and clarifying the --lowvram option's behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit 5d5a455 into master May 16, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch May 16, 2026 00:59
simonri pushed a commit to simonri/ComfyUI-flash-attention-3 that referenced this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant