Fix VOID failing with RuntimeError (CORE-205)#13873
Conversation
…dimension size (461).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR fixes a tile-accumulation bug in 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…dimension size (461). (Comfy-Org#13873)
start (0) + length (464) exceeds dimension size (461).Some very short and long clips were failing within
tiled_scale_multidimfunction.Root cause: The output buffer is pre-allocated using
round(get_scale(dim, total_size)), but when a callable index_formula is used (as the void 3D VAE does to handle non-linear temporal upscaling), the formula applied to an individual tile position + tile size can round up to 1-3 more pixels than what the total allocation computed. You got 464 but the buffer only had 461 slots.Fix: Before narrowing into the output buffer o, clamp l to
o.shape[d+2] - upscaled[d]— the actual remaining space. If a tile is trimmed, we narrow ps_view and mask_view from position 0 to the same l, so shapes stay consistent. Dropping the last 3 pixels of a tile that overlaps a border is harmless because those pixels are feathered to near-zero by the mask anyway.