Skip to content

[Partner Nodes] fix Quiver nodes#13851

Merged
Kosinkadink merged 1 commit into
masterfrom
fix/api-nodes/Quiver-nodes
May 12, 2026
Merged

[Partner Nodes] fix Quiver nodes#13851
Kosinkadink merged 1 commit into
masterfrom
fix/api-nodes/Quiver-nodes

Conversation

@bigcat88

@bigcat88 bigcat88 commented May 12, 2026

Copy link
Copy Markdown
Contributor

Fixes the Image URL must return an image content type error

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink
Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds explicit MIME type specification to image uploads in the Quiver node implementations. The upload_image_to_comfyapi function is called twice: once per reference image in QuiverTextToSVGNode.execute (line 146) and once for the input image in QuiverImageToSVGNode.execute (line 255). Both calls now include mime_type="image/png" to declare the image format during upload. No changes to request composition, API endpoints, response handling, or SVG output construction.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title references fixing Quiver nodes, which directly matches the changeset that updates Quiver image uploads with explicit mime_type parameters.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly addresses a specific error ('Image URL must return an image content type') and relates to the changeset which adds mime_type specifications to Quiver node image uploads.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kosinkadink Kosinkadink merged commit c9589f2 into master May 12, 2026
17 checks passed
@bigcat88 bigcat88 deleted the fix/api-nodes/Quiver-nodes branch May 12, 2026 10:10
simonri pushed a commit to simonri/ComfyUI-flash-attention-3 that referenced this pull request May 26, 2026
Signed-off-by: bigcat88 <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants