Derive InterruptProcessingException from BaseException

[blepping]

This tiny change is intended to prevent user code from doing something like:

try:
    blah()
except Exception:
    # Anything but reraising it

This breaks interrupt processing, because throw_exception_if_processing_interrupted clears the interrupt flag when it raises the exception. So the user's request to cancel the job is simply ignored and processing continues.

People should never be using that pattern in the first place, but it's actually not completely obvious that catching an exception in this way in something like a model patch would cause this kind of breakage.

I realized this was an issue because I'd been having a problem with my cancel requests being ignored and it was driving me crazy. Unfortunately, the culprit in that case was doing except: with no class, and this change won't help there.

The only direct uses of this exception in ComfyUI are catching it (or throwing it in this one place) explicitly, which will be exactly the same whether it subclasses Exception or BaseException. I have a lot of custom nodes installed and the only use I could find was catching it explicitly. I can't think of a way this change could cause issues and it makes it harder for extensions to break ComfyUI's core features.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a3320247-2ec9-4b3d-9c7f-596cd1ac592a

📥 Commits

Reviewing files that changed from the base of the PR and between db85cf0 and b861526.

📒 Files selected for processing (1)

• comfy/model_management.py

---

📝 Walkthrough

Walkthrough

The change modifies InterruptProcessingException in comfy/model_management.py to inherit from BaseException instead of Exception. This alters exception handling behavior: code using except Exception: blocks will no longer catch this exception, while explicit except BaseException: handlers or code allowing exceptions to propagate will still receive it. This is a single-line inheritance change affecting exception categorization in Python's exception hierarchy.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: making InterruptProcessingException inherit from BaseException instead of Exception.
Description check	✅ Passed	The description is directly related to the changeset, explaining the motivation behind changing InterruptProcessingException's inheritance and the problem it solves.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}