Skip to content

Make Load3D model_file optional by adding "none" choice#13379

Merged
alexisrolland merged 2 commits into
masterfrom
feature/load3d-optional-model
May 28, 2026
Merged

Make Load3D model_file optional by adding "none" choice#13379
alexisrolland merged 2 commits into
masterfrom
feature/load3d-optional-model

Conversation

@jtydhr88

Copy link
Copy Markdown
Contributor

Load3D now supports panoramic images and HDRI loading, it can serve as a viewer for those without requiring a 3D model. Previously, the node required a model file to execute. Rather than making the input optional (which would break existing workflows that rely on it being required), a "none" option is added to the combo list, allowing users to run Load3D with no model loaded.
FE Change is Comfy-Org/ComfyUI_frontend#11178

@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8105ef3-b6bd-493d-be64-72ed817e522d

📥 Commits

Reviewing files that changed from the base of the PR and between 31283d2 and 4fe06a2.

📒 Files selected for processing (1)
  • comfy_extras/nodes_load_3d.py

📝 Walkthrough

Walkthrough

The Load3D node in comfy_extras/nodes_load_3d.py has been modified to handle the absence of a model file more explicitly. The model_file input options now include an explicit "none" entry alongside discovered 3D files. The execute() method now conditionally constructs the Types.File3D object and determines the mesh_path output based on the input: when model_file is empty, falsey, or equals "none", both file_3d and mesh_path are set to None and an empty string respectively; otherwise they are populated from the provided model_file.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: making the Load3D model_file input optional by adding a 'none' choice.
Description check ✅ Passed The description is directly related to the changeset, explaining why the 'none' option was added (to support panoramic/HDRI viewing without a model) and how it preserves backward compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jtydhr88 added a commit to Comfy-Org/ComfyUI_frontend that referenced this pull request May 9, 2026
## Summary
Load3D now supports panoramic images and HDRI loading, it can serve as a
viewer for those without requiring a 3D model. Previously, the node
required a model file to execute. Rather than making the input optional
(which would break existing workflows that rely on it being required), a
"none" option is added to the combo list, allowing users to run Load3D
with no model loaded.

BE change is Comfy-Org/ComfyUI#13379

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11178-Handle-Load3D-none-model-selection-in-frontend-3416d73d365081e589b3d89bc67f75e7)
by [Unito](https://www.unito.io)
@alexisrolland alexisrolland merged commit be06873 into master May 28, 2026
16 checks passed
@jtydhr88 jtydhr88 deleted the feature/load3d-optional-model branch May 28, 2026 13:05
j0n4t pushed a commit to j0n4t/ComfyUI that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants