fix: log base directory to startup messages when --base-directory is used#13370
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request adds logging functionality for the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think this should be done |
alexisrolland
left a comment
There was a problem hiding this comment.
Actually this is fine, we can't add the log in folder_paths.py because it is imported before the log handler.
I tested this and it's fine.
Fixes #13363
Problem
When
--base-directoryis passed at startup, ComfyUI logs messages like:But it never logs a message for the base directory itself, making it hard to confirm that
--base-directorywas applied correctly.Solution
Add a
Setting base directory to: ...log message inapply_custom_paths(), consistent with how other directory overrides are reported. Thefolder_paths.base_pathvalue (already computed at import time) is used since it reflects the resolved absolute path.Testing
Run ComfyUI with
--base-directory /some/pathand verify the startup output includes: