fix(cli): sync terminal cursor with input caret for CJK IME - #1177
Open
ddddajie wants to merge 1 commit into
Open
fix(cli): sync terminal cursor with input caret for CJK IME#1177ddddajie wants to merge 1 commit into
ddddajie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recreates #1142 on top of the rewritten
mainhistory, as requested by the maintainer in the closed PR. Fixes #1128.The CLI rendered a visual caret but did not move the real terminal hardware cursor to the input position. CJK IMEs use the terminal cursor position to anchor their composition and candidate windows, which caused the popup to appear at unrelated screen locations.
This change:
MultilineInputcaretstring-widthtextBufferView.lineInfoaccess behind a guarded adapter while preserving wrapped-line semanticsline-info-changesubscription stable instead of re-subscribing on ordinary caret/value changesTests
Regression coverage includes:
Validation from #1142:
bun test cli/src/components/__tests__/multiline-input.test.tsx— 81 passed--rerun-each 3) — 243 passedgit diff --check— passedCLI typecheck was blocked by pre-existing missing
tarandreact-dom/servertypings; no errors were reported in the changed files.Manual verification
Manually verified in Windows Terminal with Microsoft Pinyin. Candidate-window positioning followed the input caret correctly across normal CJK input, cursor movement, wrapped lines, and scrolling.
This branch is rebuilt directly from the current rewritten
mainand contains a single clean commit. Previous review context: #1142.