Repository navigation
fix: stop advertising ? hint in agent init env prompts - #10445
Merged
Travis Angevine (trangevi) merged 3 commits intoOct 13, 2026
Merged
Travis Angevine (trangevi) merged 3 commits into
Travis Angevine (trangevi) merged 3 commits into
Conversation
azd ai agent init prompted for missing azure.yaml environment variables with a HelpMessage while also setting IgnoreHintKeys, so the prompt showed [Type ? for hint] but typing '?' entered a literal '?' that could be persisted as the value. - ux: only auto-generate the '[Type ? for hint]' affordance when hint keys are enabled (IgnoreHintKeys already covers secret prompts). - azure.ai.agents: keep '?' as literal input (URLs, secrets), drop the unreachable HelpMessage, and print the storage guidance above the prompts. - Add regression tests for both. Fixes Azure#10289
|
Azure Pipelines: Successfully started running 3 pipeline(s). 22 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
ext-agents
Hui Miao (huimiu)
marked this pull request as ready for review
October 13, 2026 06:57
Hui Miao (huimiu)
requested review from
JeffreyCA,
Rick Winter (RickWinter),
Eric Chen (eriolchan),
Glenn Harper (glharper),
hemarina,
Zhijie Huang (hund030),
Wei Meng (m5i-work),
Richard Park (richardpark-msft),
tg-msft,
John Miller (therealjohn),
Travis Angevine (trangevi),
JianW (v1212) and
Victor Vazquez (vhvb1989)
as code owners
October 13, 2026 06:57
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The prompt behavior needs required interactive-scenario coverage, and its public option documentation is stale.
2 open findings
What changed in this PR
Fixes misleading help hints while preserving literal ? characters in agent environment values.
Changes:
- Suppresses unreachable auto-generated hints.
- Moves storage guidance above environment prompts.
- Adds core and extension regression tests.
| File | Description |
|---|---|
cli/azd/pkg/ux/prompt.go |
Gates automatic hints on enabled hint keys. |
cli/azd/pkg/ux/confirm_prompt_test.go |
Tests hint suppression and custom hints. |
cli/azd/extensions/azure.ai.agents/internal/cmd/init_env.go |
Revises prompt guidance and preserves literal ?. |
cli/azd/extensions/azure.ai.agents/internal/cmd/init_env_test.go |
Tests prompt options and persisted URL values. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
azure.ai.agents PR buildNote This is an unsigned development build. Install it only if you trust this PR. Install the extension: azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10445/azure-ai-agents.zip"
|
Contributor
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
JeffreyCA
approved these changes
Oct 13, 2026
JeffreyCA
left a comment
JeffreyCA
left a comment
Contributor
There was a problem hiding this comment.
Looks good, approving cli/azd/pkg/ux changes
Travis Angevine (trangevi)
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azd ai agent init prompted for missing azure.yaml environment variables with a HelpMessage while also setting IgnoreHintKeys, so the prompt showed [Type ? for hint] but typing '?' entered a literal '?' that could be persisted as the value.
Fixes #10289