Closed Bug 2033117 Opened 14 days ago Closed 12 days ago

Nimbus Experimenter page's "Min Version" and "Max Version" drop-down menus are expanded to show every list element

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox149 --- unaffected
firefox150 --- fixed
firefox151 --- verified

People

(Reporter: cpeterson, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

actual_result_screenshot.png
160.67 KB, image/png
Details
expected_result_screenshot.png
10.15 KB, image/png
Details
Bug 2033117 - PseudoElementType should be a transferable property on adopt. r=#dom-core,jjaschke,keithamus
48 bytes, text/x-phabricator-request
Details | Review
Bug 2033117 - PseudoElementType should be a transferable property on adopt.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review

@ Emilio: this bug is a regression from your fix for display:inherit bug 2028130. I bisected this regression to this autoland push:

https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=77ad535441fc48b6a06281c5e9df4e32c1f777d9&tochange=bc4c0589510eb2b354e12c8d7060531ef810c7c7

Steps to reproduce

  1. Open a draft Nimbus experiment page in Experimenter (an internal Mozilla site). Here's an experiment that is still in draft mode and can be edited: https://experimenter.services.mozilla.com/nimbus/tou-experience-0-rollout-beta/update_audience/
  2. On the experiment's "Audience" page, scroll and click the blue "Save" button. Do not change anything else.

Actual result

The "Min Version" and "Max Version" drop-down menus are expanded to show every list element.

Flags: needinfo?(emilio)

Expected result

The "Min Version" and "Max Version" drop-down menus should show only one list element.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
See Also: → 2030828

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: Fixes regression from bug 2028130 which isn't quite a regression, just a latent bug, see bug 2030828.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: comment 0
  • Risk associated with taking this patch: low
  • Explanation of risk level: Oneliner for a very scoped piece of code.
  • String changes made/needed?: none
  • Is Android affected?: yes
Attachment #9571273 - Flags: approval-mozilla-release?
Flags: qe-verify+
Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/029906a044d3 https://hg.mozilla.org/integration/autoland/rev/f79d79abb3b1 PseudoElementType should be a transferable property on adopt. r=jjaschke,dom-core

https://hg.mozilla.org/mozilla-central/rev/f79d79abb3b1

Status: ASSIGNED → RESOLVED
Closed: 12 days ago
status-firefox151: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
QA Whiteboard: [qa-triage-done-c151/b150]

I have verified this issue using Firefox Nightly 151 (Build ID 20260419203536) and I can confirm that by following the steps described in comment 0, the issue is no longer reproducible:

Status: RESOLVED → VERIFIED
status-firefox151: fixed → verified

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59349 for changes under testing/web-platform/tests

Upstream PR merged by moz-wptsync-bot

Attachment #9571273 - Flags: approval-mozilla-release? → approval-mozilla-release+
QA Contact: avarro
Regressions: 2034706
No longer regressions: 2034706
Duplicate of this bug: 2033050
You need to log in before you can comment on or make changes to this bug.