The Wayback Machine - https://web.archive.org/web/20221207193135/https://github.com/WordPress/performance/pull/191
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all non-experimental modules on plugin activation #191

Merged
merged 5 commits into from Mar 2, 2022
Merged

Enable all non-experimental modules on plugin activation #191

merged 5 commits into from Mar 2, 2022

Conversation

kirtangajjar
Copy link
Member

@kirtangajjar kirtangajjar commented Feb 28, 2022

Summary

Fixes #61. Enable all non-experimental modules on plugin activation.

Fix is quiet simple so there isn't much to explain here.
@kirtangajjar kirtangajjar requested a review from felixarntz as a code owner Feb 28, 2022
@kirtangajjar
Copy link
Member Author

kirtangajjar commented Feb 28, 2022

@eclarke1 Can you please add "Needs Review" and other relevant labels as well?
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Feb 28, 2022
@kirtangajjar kirtangajjar mentioned this pull request Feb 28, 2022
Closed
@felixarntz felixarntz added this to the 1.0.0-beta.1 milestone Feb 28, 2022
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Enhancement A suggestion for improvement of an existing feature labels Feb 28, 2022
felixarntz
felixarntz reviewed Feb 28, 2022
View changes
Copy link
Member

@felixarntz felixarntz left a comment

@kirtangajjar This looks like a solid start. I left a few comments and suggestions for parts that need iteration.
admin/load.php Outdated Show resolved Hide resolved
admin/load.php Outdated Show resolved Hide resolved
admin/load.php Outdated Show resolved Hide resolved
@eclarke1 eclarke1 added the Needs Review Anything that requires code review label Feb 28, 2022
felixarntz
felixarntz approved these changes Feb 28, 2022
View changes
Copy link
Member

@felixarntz felixarntz left a comment

@kirtangajjar I've added those few requested changes and with that this looks good to me. Thank you for the PR! 🎉
mitogh
mitogh reviewed Feb 28, 2022
View changes
Copy link
Member

@mitogh mitogh left a comment

Overall looks great, few minor comments.
admin/load.php Show resolved Hide resolved
admin/load.php Show resolved Hide resolved
@kirtangajjar @mitogh
Update admin/load.php
f80fdac 
Bail if option is set with existing value

Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
@kirtangajjar kirtangajjar requested review from mitogh and felixarntz Mar 1, 2022
@kirtangajjar
Copy link
Member Author

kirtangajjar commented Mar 1, 2022

Thank you @felixarntz @mitogh for your reviews. I have committed the suggestion made by @mitogh. Please do let me know incase this needs something else from my end :)
@felixarntz
Copy link
Member

felixarntz commented Mar 1, 2022

@kirtangajjar Sorry, see my comment in #191 (comment), I'm not sure that change actually makes sense. From what I can tell it was better the way you originally had it:

  • We want to only run our logic if the option is not set.
  • But now after the change suggested by @mitogh the logic is also run if the option is set to e.g. an empty array.
  • The latter is problematic since it would mean we may override the user-defined configuration just because they disabled all modules, which is unexpected UX.
felixarntz
felixarntz requested changes Mar 1, 2022
View changes
Copy link
Member

@felixarntz felixarntz left a comment

@kirtangajjar One thing remaining here per the above.

cc @mitogh
admin/load.php Outdated Show resolved Hide resolved
@kirtangajjar @felixarntz
Update admin/load.php
d8495cc 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@kirtangajjar kirtangajjar requested a review from felixarntz Mar 2, 2022
@kirtangajjar
Copy link
Member Author

kirtangajjar commented Mar 2, 2022

@felixarntz Fixed. Sorry didn't think that one through fully.
mitogh
mitogh approved these changes Mar 2, 2022
View changes
felixarntz
felixarntz approved these changes Mar 2, 2022
View changes
Copy link
Member

@felixarntz felixarntz left a comment

Thank you @kirtangajjar for the PR - awesome work! 🙌
@felixarntz felixarntz merged commit b483ca7 into WordPress:trunk Mar 2, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure Needs Review Anything that requires code review [Type] Enhancement A suggestion for improvement of an existing feature
4 participants
@kirtangajjar @felixarntz @mitogh @eclarke1