Added python implementation of dynamic array #6193
Conversation
ghost
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| class DynamicArray(object): | ||
|
|
||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.capacity = 1 | ||
| self.array = self.make_array(self.capacity) | ||
|
|
||
| def __len__(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/dynamic_array/dynamic_array.py, please provide doctest for the function __len__
Please provide return type hint for the function: __len__. If the function does not return a value, please provide the type hint as: def function() -> None:
| def __len__(self): | ||
| return self.length | ||
|
|
||
| def __getitem__(self, k): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/dynamic_array/dynamic_array.py, please provide doctest for the function __getitem__
Please provide return type hint for the function: __getitem__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: k
Please provide type hint for the parameter: k
| return IndexError(f"{k} Out of Bounds") | ||
| return self.array[k] | ||
|
|
||
| def append(self, elem): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/dynamic_array/dynamic_array.py, please provide doctest for the function append
Please provide return type hint for the function: append. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: elem
| self.array[self.length] = elem | ||
| self.length += 1 | ||
|
|
||
| def _resize(self, newCapacity): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/dynamic_array/dynamic_array.py, please provide doctest for the function _resize
Please provide return type hint for the function: _resize. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: newCapacity
Please provide type hint for the parameter: newCapacity
| self.array = B | ||
| self.capacity = newCapacity | ||
|
|
||
| def make_array(self, newCapacity): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/dynamic_array/dynamic_array.py, please provide doctest for the function make_array
Please provide return type hint for the function: make_array. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: newCapacity
Please provide type hint for the parameter: newCapacity
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that have failing tests. |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.