The Wayback Machine - https://web.archive.org/web/20220402041728/https://github.com/JuliaLang/julia/pull/44311
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #43411, wrapped NamedTuple can be bitstype more often #44311

Merged
merged 1 commit into from Feb 24, 2022
Merged

fix #43411, wrapped NamedTuple can be bitstype more often #44311

merged 1 commit into from Feb 24, 2022

Conversation

JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Feb 22, 2022

fix #43411
@JeffBezanson JeffBezanson added bugfix backport 1.7 backport 1.8 labels Feb 22, 2022
vtjnash
vtjnash reviewed Feb 22, 2022
View changes
Copy link
Member

@vtjnash vtjnash left a comment •
edited

Seems like jl_get_fieldtypes is sometimes invalid for NamedTuple, as a special case here:

julia/src/jltypes.c

Line 1519 in afd9926

ndt->types = jl_emptysvec; // XXX: this is essentially always false
and we need to avoid using it, as this PR does

But if jl_get_fieldtypes was returning svec() here, how did we end up returning 1 from this function? Ah, I see we were incorrectly returning 0 here earlier, since the fieldtypes we considered were incorrect.
@vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Feb 22, 2022

Is this comment unnecessary now?

julia/src/jltypes.c

Lines 228 to 229 in afd9926

if (jl_is_tuple_type(dt) || jl_is_namedtuple_type(dt))
return 0; // TODO: relax more?

@KristofferC KristofferC mentioned this pull request Feb 23, 2022
Open
24 tasks
@KristofferC KristofferC mentioned this pull request Feb 23, 2022
Merged
33 tasks
@JeffBezanson JeffBezanson mentioned this pull request Feb 23, 2022
Closed
@KristofferC KristofferC mentioned this pull request Feb 24, 2022
Merged
47 tasks
@JeffBezanson JeffBezanson merged commit f20d5de into master Feb 24, 2022
16 checks passed
@JeffBezanson JeffBezanson deleted the jb/fix43411 branch Feb 24, 2022
staticfloat added a commit to JuliaCI/julia-buildkite-testing that referenced this issue Mar 2, 2022
@JeffBezanson @staticfloat
fix JuliaLang#43411, wrapped NamedTuple can be bitstype more often (J…
99d6c0e 
…uliaLang#44311)
KristofferC added a commit that referenced this issue Mar 3, 2022
@JeffBezanson @KristofferC
fix #43411, wrapped NamedTuple can be bitstype more often (#44311)
deb3049 
(cherry picked from commit f20d5de)
KristofferC added a commit that referenced this issue Mar 7, 2022
@JeffBezanson @KristofferC
fix #43411, wrapped NamedTuple can be bitstype more often (#44311)
e12020f 
(cherry picked from commit f20d5de)
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Mar 8, 2022
@JeffBezanson @LilithHafner
fix JuliaLang#43411, wrapped NamedTuple can be bitstype more often (J…
7d29b16 
…uliaLang#44311)
@vtjnash vtjnash mentioned this pull request Mar 14, 2022
Closed
@KristofferC KristofferC removed the backport 1.8 label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7 bugfix
3 participants
@JeffBezanson @vtjnash @KristofferC