The Wayback Machine - https://web.archive.org/web/20220226185841/https://github.com/JuliaLang/julia/pull/43735
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.6: Backports for 1.6.6 #43735

Open
wants to merge 18 commits into
base: release-1.6
Choose a base branch
from
Open

Conversation

@KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented Jan 10, 2022 •

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

cljord and others added 6 commits Jan 10, 2022
Not checking could lead to a segfault on closed TCPSockets in getpeername

Fixes #40993

(cherry picked from commit 28e30a3)
* Look for package name in `[extras]`

When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the `[extras]` entries in the project path.

Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml

Fixes JuliaPackaging/Preferences.jl#24

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 8197c41)
The last entry sentinel for Win64 SEH is `~0L` not NULL. Apparently
this doesn't cause issues on windows proper, but does crash wine.
Arguably if Windows doesn't have issues then we should just fix
this in wine, but since we control the source and nobody else
ever seems to have run into this, let's just fix it and save
the good Wine folks some headache. Fixes #43569.

(cherry picked from commit 722f9d4)
Constructing the Regex touched in this commit can represent a
significant fraction (e.g. half or better) of the runtime of
the DateFormat method touched in this commit. To make this
DateFormat method more efficient, let's lift that Regex
construction out of that method body.

(cherry picked from commit 7fb5bb8)
See comment in diff for explanation. This fixes test/stacktraces.jl
on aarch64 macOS 12, and according to an OpenJDK issue where they
ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193,
probably also x86_64 macOS 12.

(cherry picked from commit 7f27dea)
To avoid the compiler potentially picking the wrong size depending on standards versions.

(cherry picked from commit e8d1167)
@t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jan 14, 2022

@KristofferC, should #43787 be backported to 1.6.6 and also 1.7.2 ?

@KristofferC
Copy link
Sponsor Member Author

@KristofferC KristofferC commented Jan 14, 2022

Not sure, could be argued it is a bug fix but it isn't really clear to me at least.

@t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jan 14, 2022

Thanks, I'd say it's a bug fix but since it's a long standing one with visual changes, maybe @JeffBezanson can make that call.

KristofferC and others added 12 commits Jan 20, 2022
We could also consider adding `defalg(v::AbstractArray{<:Number}) = DEFAULT_UNSTABLE`,
but it is unlikely that someone will want to do `Union` of `<:Number`
and something other than `Missing` that still would support comparison.

Relevant for JuliaStrings/InlineStrings.jl#21
(and other custom types that will want to add `defalg` support allowing
for `Union` with `Missing`).

(cherry picked from commit eb724e0)
(cherry picked from commit 9769024)
(cherry picked from commit 4c101a1)
Because we might not have synchronized the list again yet.

(cherry picked from commit cac90b5)
We have 2 copies of this data, and so need to make sure we are pointing
at the correct one for runtime.

(cherry picked from commit 2f1f2f6)
@vtjnash vtjnash force-pushed the backports-release-1.6 branch from f5ab4fd to 7452018 Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment