New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-1.6: Backports for 1.6.6 #43735
Open
KristofferC
wants to merge
18
commits into
release-1.6
Choose a base branch
from
backports-release-1.6
base: release-1.6
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit 8197c41)
The last entry sentinel for Win64 SEH is `~0L` not NULL. Apparently this doesn't cause issues on windows proper, but does crash wine. Arguably if Windows doesn't have issues then we should just fix this in wine, but since we control the source and nobody else ever seems to have run into this, let's just fix it and save the good Wine folks some headache. Fixes #43569. (cherry picked from commit 722f9d4)
Constructing the Regex touched in this commit can represent a significant fraction (e.g. half or better) of the runtime of the DateFormat method touched in this commit. To make this DateFormat method more efficient, let's lift that Regex construction out of that method body. (cherry picked from commit 7fb5bb8)
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12. (cherry picked from commit 7f27dea)
To avoid the compiler potentially picking the wrong size depending on standards versions. (cherry picked from commit e8d1167)
|
@KristofferC, should #43787 be backported to |
|
Not sure, could be argued it is a bug fix but it isn't really clear to me at least. |
|
Thanks, I'd say it's a bug fix but since it's a long standing one with visual changes, maybe @JeffBezanson can make that call. |
We could also consider adding `defalg(v::AbstractArray{<:Number}) = DEFAULT_UNSTABLE`,
but it is unlikely that someone will want to do `Union` of `<:Number`
and something other than `Missing` that still would support comparison.
Relevant for JuliaStrings/InlineStrings.jl#21
(and other custom types that will want to add `defalg` support allowing
for `Union` with `Missing`).
(cherry picked from commit eb724e0)
(cherry picked from commit 9769024)
(cherry picked from commit c3235cd)
(cherry picked from commit 4c101a1)
(cherry picked from commit 2db86f2)
(cherry picked from commit c839221)
(cherry picked from commit 0c44d23)
Because we might not have synchronized the list again yet. (cherry picked from commit cac90b5)
We have 2 copies of this data, and so need to make sure we are pointing at the correct one for runtime. (cherry picked from commit 2f1f2f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


Backported PRs:
Need manual backport:
Contains multiple commits, manual intervention needed:
Base.runtests: rename the--force-netoption to--ci-->Non-merged PRs with backport label:
The text was updated successfully, but these errors were encountered: