The Wayback Machine - https://web.archive.org/web/20211026020042/https://github.com/TheAlgorithms/Python/pull/5433
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

length_conversion.py: Deal with uppercase and abbreviations #5433

Merged
merged 2 commits into from Oct 19, 2021
Merged

length_conversion.py: Deal with uppercase and abbreviations #5433

merged 2 commits into from Oct 19, 2021

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Oct 19, 2021

Describe your change:

length_conversion.py: Deal with uppercase and abbreviations

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits Oct 19, 2021
@cclauss
length_conversion.py: Deal with uppercase and abbreviations
90b1c06
updating DIRECTORY.md
2b67cec
@cclauss cclauss requested a review from poyea Oct 19, 2021
poyea
poyea approved these changes Oct 19, 2021
View changes
Copy link
Member

@poyea poyea left a comment

👀 👍
@cclauss cclauss merged commit f780433 into master Oct 19, 2021
3 checks passed
@cclauss cclauss deleted the length_conversion.py branch Oct 19, 2021
shermanhui added a commit to shermanhui/Python that referenced this issue Oct 22, 2021
@cclauss @shermanhui
length_conversion.py: Deal with uppercase and abbreviations (TheAlgor…
e646f89 
…ithms#5433)

* length_conversion.py: Deal with uppercase and abbreviations

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
2 participants
@cclauss @poyea