The Wayback Machine - https://web.archive.org/web/20201210084739/https://github.com/apple/swift/commits?author=benlangmuir
Skip to content
Permalink
main

Commits on Dec 10, 2020

  1. Merge pull request #35027 from benlangmuir/fix-sourcekitd-getInitiali…

    …zationInfo-race
    
    [sourcekit] Prevent race between getInitializationInfo and requests
    benlangmuir committed Dec 10, 2020

Commits on Dec 9, 2020

  1. [sourcekit] Prevent race between getInitializationInfo and requests

    Request handling happens on a global queue, so we need to use a
    barrier_async on the same queue to ensure the initialization finishes
    before requests are handled.
    benlangmuir committed Dec 9, 2020

Commits on Dec 2, 2020

  1. Merge pull request #34920 from nkcsgexi/71898247

    test: recover Driver/opt-record.swift
    benlangmuir committed Dec 2, 2020

Commits on Dec 1, 2020

  1. Merge pull request #34911 from benlangmuir/disable-some-tests-ci

    [test] Disable some tests failing in specific configurations pending investigation
    benlangmuir committed Dec 1, 2020
  2. [test] Mark two SILOptimizer tests requiring asserts

    Pending investigation: rdar://71857770
    benlangmuir committed Dec 1, 2020
  3. [test] Disable IRGen/unmanaged_objc_throw_func.swift with non-optimiz…

    …ed stdlib
    
    Pending investigation rdar://71857262
    benlangmuir committed Dec 1, 2020

Commits on Nov 21, 2020

  1. Merge pull request #34856 from benlangmuir/rdar71642726

    [test] Temporarily disable AutoDiff tests failing with optimizations
    benlangmuir committed Nov 21, 2020
  2. [test] Temporarily disable AutoDiff tests failing with optimizations

    These recently started failing when optimized. Disable while we
    investigate and fix.
    
    rdar://71642726
    benlangmuir committed Nov 21, 2020

Commits on Nov 20, 2020

  1. Merge pull request #34851 from benlangmuir/rdar71641343

    [test] Update SILOptimizer/OSLogFullOptTest.swift
    benlangmuir committed Nov 20, 2020
  2. [test] Update SILOptimizer/OSLogFullOptTest.swift

    After recent changes we have eliminated one of the retain/release pairs.
    
    rdar://71641343
    benlangmuir committed Nov 20, 2020
  3. Merge pull request #34836 from slavapestov/fix-rdar71560719

    Fix test/IRGen/objc_generic_class_stub.swift again
    benlangmuir committed Nov 20, 2020

Commits on Nov 18, 2020

  1. Merge pull request #34790 from benlangmuir/71468441

    [test] Disable test failing rarely in CI until we can fix it
    benlangmuir committed Nov 18, 2020

Commits on Nov 17, 2020

  1. [test] Disable test failing rarely in CI until we can fix

    rdar://71468441
    benlangmuir committed Nov 17, 2020

Commits on Nov 11, 2020

  1. Merge pull request #34672 from benlangmuir/sourcekit-inproc-and-xpc-t…

    …ogether
    
    [sourcekit] Make it possible to install both sourcekitdInProc and sourcekitd efficiently
    benlangmuir committed Nov 11, 2020

Commits on Nov 10, 2020

  1. [sourcekit] Fix InProc exports on Windows

    We only need the C++ symbols on Darwin, so avoid the issue of different
    manglings.
    benlangmuir committed Nov 10, 2020
  2. [sourcekit] Avoid duplicating implementation of InProc and XPC servic…

    …e when possible
    
    When installing both InProc and XPC versions of sourcekitd, dynamically
    link the XPC service to the InProc version. This lets us install both
    frameworks without wasting the disk space from having another copy of
    the swift frontend statically linked.
    benlangmuir committed Nov 10, 2020
  3. [sourcekit] Enable installing both sourcekitdInProc and sourcekitd

    Makes it possible to build and install both sourcekitdInProc and the XPC
    service on Darwin.
    benlangmuir committed Nov 10, 2020
  4. Merge pull request #34657 from benlangmuir/fix-cursor-test

    [test] Fix test/SourceKit/CursorInfo/invalid_offset
    benlangmuir committed Nov 10, 2020
  5. [sourcekit] Sink UID handling into the API library

    This fixes a layering violation where UID handling was provided by a
    dependent library, creating a dependency cycle if you tried to link the
    lower level libraries dynamically.
    benlangmuir committed Nov 10, 2020
  6. [sourcekit] Refactor notification handling layering

    This refactors notification handling so that the XPC service and InProc
    library pass in their notification handler callback. This fixes a
    layering issue where the sourcekitd libraries could not be linked
    dynamically due to the missing symbols.
    benlangmuir committed Nov 10, 2020
  7. [test] Fix test/SourceKit/CursorInfo/invalid_offset

    This test was intended to catch a crash on invalid offset, but in rare
    cases it was failing spuriously, because the error message depends on
    non-deterministic behaviour. It's sufficient for this test that it
    doesn't crash.
    
    rdar://63187529
    benlangmuir committed Nov 10, 2020

Commits on Oct 28, 2020

  1. [test] Update cross_langauge index test for mangling change

    benlangmuir committed Oct 28, 2020

Commits on Sep 29, 2020

  1. Merge pull request #34117 from benlangmuir/cache-size-off-by-3

    [code-completion] Fix cache writer for non-decl kind
    benlangmuir committed Sep 29, 2020
  2. [code-completion] Fix cache writer for non-decl kind

    Thanks to Ben Barham for spotting this:
    sizeof(~static_cast<uint8_t>(...)) is 4, but we need to write a single
    byte here. Thankfully this code was probably not being hit in the
    current caching scheme, which only caches declarations.
    
    Looking at the history, this code was broken by d8fbaa0, which was
    fixing an MSVC warning in this code. Unfortunately I do not have access
    to the version of MSVC to check if there is still a warning here or for
    what.
    benlangmuir committed Sep 29, 2020

Commits on Aug 25, 2020

  1. Merge pull request #33632 from benlangmuir/gardening-libIDE

    [gardening] Move some code between sourcekitd and libIDE
    benlangmuir committed Aug 25, 2020
  2. Move FuzzyStringMatcherTest to IDE unittests

    benlangmuir committed Aug 25, 2020
  3. Fix missing dependency

    benlangmuir committed Aug 25, 2020
  4. Move adjustClangTriple above its only caller

    benlangmuir committed Aug 25, 2020
  5. [gardening] format changed code

    benlangmuir committed Aug 25, 2020

Commits on Aug 3, 2020

  1. Merge pull request #33236 from benlangmuir/semantic-highlight-test-ra…

    …ce3000
    
    [sourcekitd] Fix potential race in semantic highlighting tests
    benlangmuir committed Aug 3, 2020

Commits on Jul 31, 2020

  1. [sourcekitd] Fix potential race in semantic highlighting tests

    In order to make range-shifting for semantic highlighting testable,
    disable returning semantic information during an "open" request. This
    has no real value anyway, since it only happens very rarely, and it
    makes testing range shifting impossible to do deterministically.
    
    rdar://problem/66386179
    benlangmuir committed Jul 31, 2020
Older
You can’t perform that action at this time.