The Wayback Machine - https://web.archive.org/web/20201023163242/https://github.com/angular/angular-cli/issues/18393
Skip to content

/ angular-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: detect the absence of the `node_modules` folder while running `ng build` or `ng serve` #18393

Open
AndrewKushnir opened this issue Jul 28, 2020 · 3 comments
Open

Proposal: detect the absence of the `node_modules` folder while running `ng build` or `ng serve` #18393

AndrewKushnir opened this issue Jul 28, 2020 · 3 comments
Labels
comp: angular/cli freq1: low severity2: inconvenient type: bug/fix
Milestone
Backlog

Comments

@AndrewKushnir
Copy link

@AndrewKushnir AndrewKushnir commented Jul 28, 2020

🚀 Feature request

Command

  • build
  • serve

Description

Running ng build or ng serve in a folder without node_modules present results in the following error thrown in terminal:

$ ng serve
An unhandled exception occurred: Cannot find module '@angular-devkit/build-angular/package.json'
Require stack:
... stacktrace ...
See "/private/var/folders/7d/r6b3nrdj7bn9t_w_dclm6y9r00kg80/T/ng-PRpMHw/angular-errors.log" for further details.

This can happen for example after downloading an example app from angular.io website. Example link:

https://angular.io/generated/zips/form-validation/form-validation.zip

Describe the solution you'd like

The proposal is to handle the case when node_modules folder is not present and output a user-friendly error message that would suggest to run npm install or yarn install.
@ngbot ngbot bot modified the milestone: Backlog Jul 29, 2020
@sahilpurav
Copy link

@sahilpurav sahilpurav commented Aug 16, 2020

Instead of showing a message, how if we automatically do npm install or yarn install
@codebriefcase
Copy link

@codebriefcase codebriefcase commented Sep 11, 2020

Such errors seems to be mind-boggling when I was very new to Angular.
These needs to be exact and clear to the end user.
@elvisbegovic
Copy link
Contributor

@elvisbegovic elvisbegovic commented Sep 11, 2020

Same with ng new ap --skip-install && cd ap && ng version

This is somehow related to #10474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: angular/cli freq1: low severity2: inconvenient type: bug/fix
5 participants
@elvisbegovic @sahilpurav @alan-agius4 @AndrewKushnir @codebriefcase
You can’t perform that action at this time.