WIP: show a nice stacktrace when breaking on error #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With JuliaDebug/JuliaInterpreter.jl#214 (the point is the stacktraces): julia> f() = "αβ"[2]
f (generic function with 1 method)
julia> @enter f()
In f() at REPL[8]:1
>1 f() = "αβ"[2]
About to run: (getindex)("αβ", 2)
1|debug> c
ERROR: StringIndexError("αβ", 2)
Stacktrace:
[1] string_index_err(::String, ::Int64) at strings/string.jl:12
[2] getindex_continued(::String, ::Int64, ::UInt32) at strings/string.jl:218
[3] getindex(::String, ::Int64) at strings/string.jl:211
[4] f() at REPL[8]:1
julia> @run f()
ERROR: StringIndexError("αβ", 2)
Stacktrace:
[1] string_index_err(::String, ::Int64) at strings/string.jl:12
[2] getindex_continued(::String, ::Int64, ::UInt32) at strings/string.jl:218
[3] getindex(::String, ::Int64) at strings/string.jl:211
[4] f() at REPL[8]:1
julia> break_on(:error)
julia> @enter f()
In f() at REPL[8]:1
>1 f() = "αβ"[2]
About to run: (getindex)("αβ", 2)
1|debug> c
Breaking for error:
ERROR: StringIndexError("αβ", 2)
Stacktrace:
[1] string_index_err(::String, ::Int64) at strings/string.jl:12
[2] getindex_continued(::String, ::Int64, ::UInt32) at strings/string.jl:218
[3] getindex(::String, ::Int64) at strings/string.jl:211
[4] f() at REPL[8]:1
In string_index_err(s, i) at strings/string.jl:12
>12 @noinline string_index_err(s::AbstractString, i::Integer) =
About to run: (throw)(StringIndexError("αβ", 2))
1|debug> |
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
===========================================
- Coverage 80.59% 46.97% -33.62%
===========================================
Files 7 7
Lines 474 447 -27
===========================================
- Hits 382 210 -172
- Misses 92 237 +145
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Need to figure out how to deal with the absolute paths in the stacktrace when breaking on error. There isn't really a nice way to change this.
Fixes #145