fix(ci): Build deb/rpm packages in the release workflow and drop promtail - #23680
Merged
Conversation
…tail
When the release build moved off loki-build-image (which bundled nfpm) to a
plain golang container, install_workflow_dependencies.sh never
installed nfpm. tools/packaging/nfpm.sh then failed to find nfpm and,
lacking `set -e`, swallowed the error - so releases silently shipped
without .deb/.rpm packages (v3.6.12, v3.6.13, v3.7.3, v3.7.4).
This PR:
- bumps the vendored loki-release to a ref that installs nfpm@v2.45.2
- hardens nfpm.sh with `set -euo pipefail`
- drops promtail from the packaged components (no longer built for release)
- removes the orphaned verify-{deb,rpm}-install.sh scripts that only exercised the removed promtail package.
6 tasks
Contributor
Author
|
Rebase after #23686 is merged |
Contributor
|
The backport to To backport manually, run these commands in your terminal: git fetch
git switch --create backport-23680-to-release-3.6.x origin/release-3.6.x
git cherry-pick -x 7061803f016ac3eeb5b9d1acadd33643e6b8c68aResolve the conflicts, then add the changes and run git add . && git cherry-pick --continueIf you have the GitHub CLI installed: git push --set-upstream origin backport-23680-to-release-3.6.x
PR_BODY=$(gh pr view 23680 --json body --template 'Backport 7061803f016ac3eeb5b9d1acadd33643e6b8c68a from #23680{{ "\n\n---\n\n" }}{{ index . "body" }}')
echo "${PR_BODY}" | gh pr create --title 'fix(ci): Build deb/rpm packages in the release workflow and drop promtail [release-3.6.x]' --body-file - --label 'backport' --label '' --base release-3.6.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): git push --set-upstream origin backport-23680-to-release-3.6.xAnd open a pull request where the |
jnewbigin
added a commit
that referenced
this pull request
Aug 3, 2026
This was referenced Aug 3, 2026
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backport of #23598 to
main: restore.deb/.rpmpackage production in the release build, and finish removing promtail from packaging.Why
When the release build moved off
loki-build-image(which bundlednfpm) to a plaingolang:1.26.5container,install_workflow_dependencies.shnever installednfpm.tools/packaging/nfpm.shthen failed to findnfpmand, lackingset -e, swallowed the error. End result was that releases silently shipped without any.deb/.rpmassets.A fix was made on the
release-3.7.xbranch. This ports the fix tomainChanges
.github/jsonnetfile.json+.lock.json: bump vendoredgrafana/loki-releasea02bbf94→79fc5eab, which addsgo install github.com/goreleaser/nfpm/v2/cmd/nfpm@v2.45.2toinstall_dist_dependencies().make release-workflows. The workflow changes are purely the lib-ref hash bump.tools/packaging/nfpm.sh: addset -euo pipefailso a missing tool fails loudly instead of silentlypromtailfrom the packaged componentstools/packaging/verify-{deb,rpm}-install.sh. Orphaned scripts that exercised the promtail package.Testing / validation
a02bbf94→79fc5eablib-ref hash (noGO_VERSIONor other churn)..deb/.rpm(18/18 each) with the pinnednfpm.shellcheckclean onnfpm.sh.Notes
SHA256SUMSdoes not (and never did) include the OS package files