fix: LineFilterLabelFilter.String() regexp correct delimiters (backport release-3.6.x) - #20649
Merged
Merged
Conversation
When the querysharder executes, it converts a query into an AST representation before forwarding it on to the queriers. Unfortunately, when this AST representation is converted back into a string, it does not handle the case where a regexp can contain backticks - it always tries to wrap the regexp in backticks, which can lead to parser errors. This PR updates the String() method that converted the filter back into a query string and adapts the delimiters based on the content of the regexp. (cherry picked from commit 0303aee)
trevorwhitney
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 0303aee from #17129
What this PR does / why we need it:
When the querysharder executes, it converts a query into an AST representation before forwarding it on to the queriers. Unfortunately, when this AST representation is converted back into a string, it does not handle the case where a regexp can contain backticks - it always tries to wrap the regexp in backticks, which can lead to parser errors. This PR updates the String() method that converted the filter back into a query string and adapts the delimiters based on the content of the regexp.
Which issue(s) this PR fixes:
Fixes #16674
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR